在交付前 拦住 LLM 的坏代码

# Code review: <file or scope>

## Summary
<2–3 sentence verdict: ship / needs work / rewrite>

## Critical findings
<must-fix before merge>
- **<short title>** — `<file>:<line>`
  Evidence: <quoted code or behavior>
  Principle violated: <e.g., LSP, catch-all error swallowing>
  Suggested fix: <concrete>

## Important findings
<should fix but not blocking>
- ...

## Nits
<style, naming, minor structure>
- ...

## What's good
<at least 2–3 specific positives — naming, structure, test coverage>

## Self-check coverage
- [ ] Walked Section A (naming & functions)
- [ ] Walked Section B (comments & formatting)
- [ ] Walked Section C (SOLID)
- [ ] Walked Section D (DRY/KISS/YAGNI)
- [ ] Walked Section E (AI failure modes)

getEmail(userId):
  attempt:
    user = userStore.get(userId)
    return user.email
  catch anyError:
    return null

getEmail(userId):
  user = userStore.get(userId)  # errors propagate
  return user.email

total(orderItems):
  if orderItems is null: return 0
  if orderItems is not a collection: return 0
  return sum(order.amount for each non-null order in orderItems)

total(orderItems):
  return sum(order.amount for each order in orderItems)

PaymentProcessor interface
  charge(amount)
CardPaymentProcessor implements PaymentProcessor
  charge(amount):
    return paymentProvider.createCharge(amount).id
PaymentProcessorFactory
  create():
    return new CardPaymentProcessor()

charge(amount):
  return paymentProvider.createCharge(amount).id

processData(data):
  result = []
  for item in data:
    temp = item.value * 2
    result.add(temp)
  return result

doublePrices(orders):
  return orders.map(order -> order.priceCents * 2)

sendEmail(to, subject, body, retry=true, backoff="exp",
          html=false, fromAddress=null, encoding="utf-8",
          internal=false, verbose=false)

EmailRequest
  to
  subject
  body
  html = false

sendEmail(request: EmailRequest)

getUserBalance(userId):
  return 1000  # TODO: actual provider call

getUserBalance(userId):
  raise NotImplemented("Wire to billing.getBalance() after auth is available")

median = (values[values.length / 2] + values[values.length / 2 + 1]) / 2

# BAD — silently drops items[0]
for index from 1 to items.length - 1:
  ...

# cases: empty / one / even / odd
median(values):
  sorted = values.sort()
  mid = sorted.length / 2
  return sorted.length % 2 == 0
    ? (sorted[mid-1] + sorted[mid]) / 2
    : sorted[mid]